Skip to content

fix: generic option to add banner #5272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rebelchris merged 2 commits into from
Jan 9, 2026
Merged

fix: generic option to add banner #5272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12a2c68
fix: generic option to add banner
rebelchris Jan 9, 2026
a26e9a0
fix: pr feedback
rebelchris Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/shared/src/components/opportunity/SideBySideEdit/OpportunityEditPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
import { ArrowIcon } from '../../icons';
import { IconSize } from '../../Icon';
import type { Opportunity } from '../../../features/opportunity/types';
import { settingsUrl, webappUrl } from '../../../lib/constants';
import { RoleInfoSection } from './sections/RoleInfoSection';
import { JobDetailsSection } from './sections/JobDetailsSection';
import { ContentSection } from './sections/ContentSection';
Expand Down Expand Up @@ -192,7 +193,9 @@ export function OpportunityEditPanel({
name={recruiter?.name}
image={recruiter?.image}
subtitle={recruiter?.title}
editUrl="/settings/profile"
editUrl={`${settingsUrl}/profile?redirectTo=${encodeURIComponent(
`${webappUrl}recruiter/${opportunity.id}/edit`,
)}&redirectCopy=${encodeURIComponent('Back to job posting')}`}
emptyMessage="No recruiter info added yet"
/>
</div>
Expand Down
4 changes: 3 additions & 1 deletion packages/shared/src/components/recruiter/layout/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ const Footer = () => {
variant={ButtonVariant.Tertiary}
icon={<SettingsIcon />}
size={ButtonSize.XSmall}
href={`${settingsUrl}/profile`}
href={`${settingsUrl}/profile?redirectTo=${encodeURIComponent(
Copy link
Contributor

@capJavert capJavert Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why encode it? could use getPathnameWithQuery or just URL

Copy link
Contributor Author

@rebelchris rebelchris Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually forgot we had that one

`${webappUrl}recruiter`,
)}&redirectCopy=${encodeURIComponent('Back to recruiter dashboard')}`}
tag="a"
/>
<Button
Expand Down
17 changes: 16 additions & 1 deletion packages/webapp/components/layouts/SettingsLayout/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import useAuthForms from '@dailydotdev/shared/src/hooks/useAuthForms';
import dynamic from 'next/dynamic';
import {
Typography,
TypographyColor,
TypographyTag,
TypographyType,
} from '@dailydotdev/shared/src/components/typography/Typography';
Expand Down Expand Up @@ -133,7 +134,21 @@ export default function SettingsLayout({
/>
</div>
)}

{router.query.redirectTo && router.query.redirectCopy && (
<button
type="button"
onClick={() => router.push(router.query.redirectTo as string)}
className="flex w-full items-center justify-center gap-2 border-b border-border-subtlest-tertiary bg-surface-float px-6 py-3 text-left transition-colors hover:bg-surface-hover"
>
<ArrowIcon className="-rotate-90 text-text-tertiary" />
<Typography
type={TypographyType.Callout}
color={TypographyColor.Secondary}
>
{router.query.redirectCopy}
</Typography>
</button>
)}
<div className="mx-auto flex w-full max-w-5xl gap-4 tablet:p-6">
{isMobile ? (
<ProfileSettingsMenuMobile
Expand Down