Reclassify rejection feedback on subsequent submissions

Author: davidercruz

__tests__/workers/opportunity/parseOpportunityFeedback.ts

@@ -277,7 +277,7 @@ describe('parseOpportunityFeedback worker', () => {
     });
   });
 
-  it('should skip classifyRejectionFeedback when already classified', async () => {
+  it('should reclassify when already classified', async () => {
     await con.getRepository(OpportunityMatch).save({
       opportunityId: testOpportunityId,
       userId: '1',
@@ -299,6 +299,20 @@ describe('parseOpportunityFeedback worker', () => {
       },
     });
 
+    mockClassifyRejectionFeedback.mockResolvedValue({
+      id: 'test-id',
+      classification: {
+        reasons: [
+          {
+            reason: 5,
+            confidence: 0.91,
+            explanation: 'Candidate prefers another area',
+          },
+        ],
+        summary: 'Updated classification',
+      },
+    });
+
     await expectSuccessfulTypedBackground<'api.v1.opportunity-feedback-submitted'>(
       worker,
       {
@@ -307,7 +321,22 @@ describe('parseOpportunityFeedback worker', () => {
       },
     );
 
-    expect(mockClassifyRejectionFeedback).not.toHaveBeenCalled();
+    expect(mockClassifyRejectionFeedback).toHaveBeenCalled();
+
+    const updatedMatch = await con.getRepository(OpportunityMatch).findOne({
+      where: { opportunityId: testOpportunityId, userId: '1' },
+    });
+
+    expect(updatedMatch?.rejectionClassification).toEqual({
+      reasons: [
+        {
+          reason: 5,
+          confidence: 0.91,
+          explanation: 'Candidate prefers another area',
+        },
+      ],
+      summary: 'Updated classification',
+    });
   });
 
   it('should handle ConnectError from classifyRejectionFeedback gracefully', async () => {

src/workers/opportunity/parseOpportunityFeedback.ts

@@ -93,19 +93,6 @@ const parseOpportunityFeedback = async ({
     'Successfully parsed opportunity feedback',
   );
 
-  const hasRejectionClassification =
-    !!match.rejectionClassification &&
-    Array.isArray(match.rejectionClassification.reasons) &&
-    typeof match.rejectionClassification.summary === 'string';
-
-  if (hasRejectionClassification) {
-    logger.debug(
-      { opportunityId, userId },
-      'Rejection feedback already classified',
-    );
-    return;
-  }
-
   try {
     const feedback = match.feedback
       .map((item) => `Q: ${item.screening}\nA: ${item.answer}`)