Skip to content

fix: filter out unread posts for same author#2959

Merged
omBratteng merged 1 commit intomainfrom
AS-1172-filter-out-same-author
Aug 5, 2025
Merged

fix: filter out unread posts for same author#2959
omBratteng merged 1 commit intomainfrom
AS-1172-filter-out-same-author

Conversation

@omBratteng
Copy link
Contributor

@omBratteng omBratteng commented Aug 5, 2025

When there is a new unread post in a squad, we can filter out the author of the post.

Jira ticket

AS-1172

@pulumi
Copy link

pulumi bot commented Aug 5, 2025

🍹 The Update (preview) for dailydotdev/api/prod (at fa1ac10) was successful.

Resource Changes

    Name                                            Type                           Operation
~   vpc-native-hourly-notification-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tags-str-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-deployment       kubernetes:apps/v1:Deployment  update
~   vpc-native-update-views-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-stale-user-transactions-cron   kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                 kubernetes:batch/v1:CronJob    update
+   vpc-native-api-migration-32ed67c8               kubernetes:batch/v1:Job        create
~   vpc-native-sync-subscription-with-cio-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-gifted-plus-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                           kubernetes:apps/v1:Deployment  update
~   vpc-native-temporal-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-update-highlighted-views-cron        kubernetes:batch/v1:CronJob    update
~   vpc-native-generic-referral-reminder-cron       kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-calculate-top-readers-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-tag-view-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-personalized-digest-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                   kubernetes:apps/v1:Deployment  update
~   vpc-native-ws-deployment                        kubernetes:apps/v1:Deployment  update
~   vpc-native-bg-deployment                        kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-zombie-user-companies-cron     kubernetes:batch/v1:CronJob    update
-   vpc-native-api-migration-7e1cbfad               kubernetes:batch/v1:Job        delete
~   vpc-native-check-analytics-report-cron          kubernetes:batch/v1:CronJob    update

@omBratteng omBratteng requested a review from Copilot August 5, 2025 12:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements filtering logic to prevent post authors from receiving unread post notifications for their own posts in squads. When a new post is added to a squad, the system now excludes the post author from having their hasUnreadPosts flag updated.

  • Added author filtering in the squad unread posts query to exclude the post author
  • Updated existing tests to include authorId field in test data
  • Added comprehensive test coverage for the new author exclusion behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/workers/postAddedSquadUnreadPosts.ts Added query filter to exclude post author from unread posts updates
tests/workers/postAddedSquadUnreadPosts.ts Updated test data and added new test case for author exclusion
Comments suppressed due to low confidence (1)

tests/workers/postAddedSquadUnreadPosts.ts:186

  • The test expects 1 result but doesn't verify that the updated member is specifically NOT the author. The test should verify that user '1' (the author) doesn't have the hasUnreadPosts flag updated, while other members do.
    expect(afterResult).toBe(1);

@omBratteng omBratteng merged commit f6a93c9 into main Aug 5, 2025
9 checks passed
@omBratteng omBratteng deleted the AS-1172-filter-out-same-author branch August 5, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants