-
Notifications
You must be signed in to change notification settings - Fork 112
fix: anon user #3438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: anon user #3438
Conversation
src/schema/opportunity.ts
Outdated
| const flags = (user.flags ?? {}) as Record<string, unknown>; | ||
| userContextMap.set(user.id, { | ||
| seniority: user.experienceLevel ?? null, | ||
| locationCountry: (flags.country as string) ?? null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude I just realized country can be either this or from user_candidate_preference the latter should take priority, you can find some examples in the code already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude finished @rebelchris's task in 2m 49s —— View job
Country priority fix completed ✓
- Read the current implementation around line 1871 in src/schema/opportunity.ts
- Search for existing examples of user_candidate_preference priority pattern
- Implement fix to prioritize user_candidate_preference country over other sources
- Commit and push changes
Changes made
Updated src/schema/opportunity.ts:1867-1893 to prioritize user_candidate_preference.location.country over user.flags.country:
- Fetch candidatePreferences with location relation - Added query to fetch UserCandidatePreference records with their associated DatasetLocation
- Create preference map - Built a Map for efficient lookup of preferences by userId
- Priority logic - Updated country assignment to use
preferenceLocation?.country ?? flags.country ?? null
This ensures that when a user has explicitly set their location in their candidate preferences, that takes priority over the country stored in their user flags.
The change has been committed and pushed to the fix-anon-user branch.
| View commit
- Fetch UserCandidatePreference with location relation - Use preferenceLocation.country as primary source, fallback to flags.country - Ensures user's explicit location preference takes precedence Co-authored-by: Chris Bongers <[email protected]>
|
🍹 The Update (preview) for dailydotdev/api/prod (at 2d0f636) was successful. Resource Changes Name Type Operation
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-db-migration-ffae6b22 kubernetes:batch/v1:Job delete
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-db-migration-846f0593 kubernetes:batch/v1:Job create
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
+ vpc-native-api-clickhouse-migration-846f0593 kubernetes:batch/v1:Job create
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
- vpc-native-api-clickhouse-migration-ffae6b22 kubernetes:batch/v1:Job delete
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-opportunities-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-post-analytics-history-day-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
|
No description provided.