Skip to content

Conversation

@PascalIversen
Copy link
Collaborator

@PascalIversen PascalIversen commented Mar 5, 2025

closes #149

@github-actions github-actions bot added the bug Something isn't working label Mar 5, 2025
PascalIversen and others added 5 commits March 5, 2025 11:43
…hold

molir, superfeltr: remembering features from training dataset such that they can be subsetted in predict
test molir, superfeltr: sample a drug that is in study and cross study
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
PascalIversen and others added 12 commits March 5, 2025 13:38
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
- squared_error
n_components:
- 100
- 80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we keep it at 100 and only change it for the test?

inputs["copy_number_variation_gistic"],
inputs["fingerprints"],
)
if methylation.shape[1] != len(self.methylation_features):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we also don't need self.methylation_features anymore right?

@JudithBernett JudithBernett merged commit 7ee903a into development Mar 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cross study prediction: sort features

3 participants