Skip to content

Conversation

@JudithBernett
Copy link
Contributor

Fixing all mypy errors. Also restructured class DRP a little bit:

  1. model_name is no longer an instance property but a class property. Because it is not possible to have class properties, it was converted into a class method get_model_name()
  2. Deleted the SingleDrugModel. It is substituted by a class attribute boolean is_single_drug_model.
  3. fixed what's needed as input for all train and predict methods and which format they should have. The DRP class has a required cell_line_input by an optional drug_input because this is None for the single drug models.

@github-actions github-actions bot added the bug Something isn't working label Nov 14, 2024
@JudithBernett JudithBernett self-assigned this Nov 14, 2024
@JudithBernett JudithBernett merged commit 3afdf81 into development Nov 14, 2024
@JudithBernett JudithBernett deleted the mypy_fix branch November 14, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants