Skip to content

1주차 과제 제출 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stbpiza wants to merge 2 commits into
base: main
Choose a base branch
from
Open

1주차 과제 제출 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5519324
과제1 Ticket 관리
stbpiza Mar 9, 2025
21e5efc
과제2 Ticket에 댓글 남기기
stbpiza Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
node 22.14.0
nodejs 22.14.0
10 changes: 6 additions & 4 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<title>Tickets</title>
<title>Demo</title>
<meta charset="UTF-8">
<link rel="stylesheet" href="styles.css">
<link rel="stylesheet" href="tickets.css">
</head>
<body>
<div id="root"></div>
<script type="module" src="src/main.tsx"></script>
<div id="root">
<!-- Root -->
</div>
<script type="module" src="tickets.tsx"></script>
</body>
</html>
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
"description": "",
"devDependencies": {
"typescript": "^5.8.2",
"vite": "^6.2.0"
"vite": "^6.2.1"
}
}
81 changes: 81 additions & 0 deletions tickets.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
html {
box-sizing: border-box;
}

*,
*::before,
*::after {
box-sizing: inherit;
}

html {
font-size: 62.5%;
}

body {
font-size: 1.6rem;
}

#ticket-list {
margin: 0;
padding: 0;
list-style: none;

li {
margin-block: 1rem;
padding: 1rem;
border: 1px solid #CCC;

.title {
font-size: 2rem;
font-weight: 700;
}

.description {
margin-block: .5rem;
}
}
}
Comment on lines +19 to +38
Copy link

@coderabbitai coderabbitai bot Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Use of nested CSS selectors may require preprocessing.

The CSS uses nested selector syntax (li { ... } inside #ticket-list), which is not supported in standard CSS without a preprocessor like Sass or a CSS bundler that supports this syntax.

🏁 Script executed:

#!/bin/bash
# Check if there's a CSS preprocessor or PostCSS configuration
echo "Checking for CSS preprocessor configuration..."
find . -maxdepth 2 -name "*.config.*" -o -name "postcss.config.*" -o -name "sass.config.*" | grep -v "node_modules"

# Check package.json for relevant dependencies
if [ -f package.json ]; then
  echo "Checking package.json for CSS preprocessors..."
  grep -E "sass|scss|less|postcss|tailwind" package.json || echo "No CSS preprocessor found in package.json"
fi

Length of output: 497

CSS Nested Selectors Require Preprocessor or Syntax Adjustment

The snippet in tickets.css (lines 19-38) uses nested selectors (e.g., li { ... } containing .title { ... } and .description { ... }), which are only valid with preprocessing (e.g., Sass). Since no such preprocessor configuration or dependency is present (as confirmed by the search in configuration files and package.json), please either configure a preprocessor or refactor the CSS to use valid, flattened selectors.

  • File: tickets.css (lines 19-38)
  • Action: Update the nested selector syntax to standard CSS or add the necessary preprocessor configuration.


#comment-list {
li {
/* max-width: 36rem; */
margin-block: 1rem;
padding: 1rem;
border: 1px solid #CCC;
}
}

.no-comments {
margin-top: 1rem;
}

form {
margin-block: 2rem;
max-width: 40rem;

div {
margin-block: 1rem;
}

label {
display: block;
margin-bottom: .4rem;
}

input,
textarea {
width: 100%;
padding: .8rem 1rem;
}

textarea {
height: 10rem;
}

button {
width: 100%;
padding: .8rem 1rem;
}
}

Loading