Issue 7: Import fails. Blank Screen. No Error Messages.#9
Open
thesamim wants to merge 4 commits intodaledesilva:mainfrom
Open
Issue 7: Import fails. Blank Screen. No Error Messages.#9thesamim wants to merge 4 commits intodaledesilva:mainfrom
thesamim wants to merge 4 commits intodaledesilva:mainfrom
Conversation
Problem with file name sanitization from title. Imported pre-built file sanitizer.
Owner
|
Wow, google keep has added a bunch of refinements to it's interface since I last opened it. Interesting. |
Owner
|
In regard to the filename sanitisation, did this actually fix your import issue? Valid filenames are different on different operating systems. Do you know if this operation takes that into account? I know from other obsidian discussions that some users don't want to be limited by restrictions that aren't relevant to their platform. I don't think that's a great the approach personally as it can create unexpected cross platform issues in the future for people, but I can't quite tell for certain from filename-santitize's npm page. Do you know? |
Owner
|
Also, thanks for writing the file extension stripping function too :) |
Owner
|
In regard to the annotations, here's json export I jsut created where I tried to switch on and add everything I could see as possible in keep. No annotations. |
Author
|
Yes, it did fix my import issue.
From: https://github.com/parshap/node-sanitize-filename, it is cross-platform compliant.
Additional thought:
The issue with Obsidian becoming unresponsive if the problem is not fixed is that there is an infinite loop created by calling the function recursively in the catch block. Even with the fix, the possibility exists that without some kind of check, an infinite loop could be created. I’d suggested that there should be a max number of “version” beyond which the function will just bail out and error.
From: Dale de Silva ***@***.***>
Sent: Friday, July 21, 2023 7:35 PM
To: daledesilva/obsidian_google-keep-import ***@***.***>
Cc: thesamim ***@***.***>; Author ***@***.***>
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
In regard to the filename sanitisation, did this actually fix your import issue <#7> ?
Valid filenames are different on different operating systems. Do you know if this operation takes that into account? I know from other obsidian discussions that some users don't want to be limited by restrictions that aren't relevant to their platform.
I don't think that's a great the approach personally as it can create unexpected cross platform issues in the future for people, but I can't quite tell for certain from filename-santitize's npm page. Do you know?
—
Reply to this email directly, view it on GitHub <#9 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIRYKIEQU7CY5MCH7BIPQTXRMN3FANCNFSM6AAAAAA2TJ3CNI> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Author
|
Welcome.
From: Dale de Silva ***@***.***>
Sent: Friday, July 21, 2023 7:35 PM
To: daledesilva/obsidian_google-keep-import ***@***.***>
Cc: thesamim ***@***.***>; Author ***@***.***>
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
Also, thanks for writing the file extension stripping function too :)
—
Reply to this email directly, view it on GitHub <#9 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIRYKPNH22U4DHOVB6HQC3XRMN4TANCNFSM6AAAAAA2TJ3CNI> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Author
|
Out of the 831 keep notes I have, 700 of them have annotations.
I think that they are notes that I’ve shared to Keep on Android. It looks like “annotations” is how they keep track of information required to show the associated web sites.
Here are a couple of examples.
From: Dale de Silva ***@***.***>
Sent: Friday, July 21, 2023 7:51 PM
To: daledesilva/obsidian_google-keep-import ***@***.***>
Cc: thesamim ***@***.***>; Author ***@***.***>
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
In regard to the annotations, here's json export I jsut created where I tried to switch on and add everything I could see as possible in keep. No annotations.
Does this come from a novel workflow that I'm not aware of?
T_h_is _is a <https://github.com/daledesilva/obsidian_google-keep-import/files/12135312/T_h_is._is.a._name_.json.zip> name.json.zip
—
Reply to this email directly, view it on GitHub <#9 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIRYKMSXKEX6LNIWJJM5Z3XRMPZBANCNFSM6AAAAAA2TJ3CNI> .
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Author
|
Strangely, the Google Keep API (https://developers.google.com/keep/api/reference/rest/v1/notes) does not document annotations at all.
From: Sami Mikhail ***@***.***>
Sent: Saturday, July 22, 2023 11:13 AM
To: 'daledesilva/obsidian_google-keep-import' ***@***.***>; 'daledesilva/obsidian_google-keep-import' ***@***.***>
Cc: 'Author' ***@***.***>
Subject: RE: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
Out of the 831 keep notes I have, 700 of them have annotations.
I think that they are notes that I’ve shared to Keep on Android. It looks like “annotations” is how they keep track of information required to show the associated web sites.
Here are a couple of examples.
From: Dale de Silva ***@***.*** ***@***.***> >
Sent: Friday, July 21, 2023 7:51 PM
To: daledesilva/obsidian_google-keep-import ***@***.*** ***@***.***> >
Cc: thesamim ***@***.*** ***@***.***> >; Author ***@***.*** ***@***.***> >
Subject: Re: [daledesilva/obsidian_google-keep-import] Issue 7: Import fails. Blank Screen. No Error Messages. (PR #9)
In regard to the annotations, here's json export I jsut created where I tried to switch on and add everything I could see as possible in keep. No annotations.
Does this come from a novel workflow that I'm not aware of?
T_h_is _is a <https://github.com/daledesilva/obsidian_google-keep-import/files/12135312/T_h_is._is.a._name_.json.zip> name.json.zip
—
Reply to this email directly, view it on GitHub <#9 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIRYKMSXKEX6LNIWJJM5Z3XRMPZBANCNFSM6AAAAAA2TJ3CNI> .
You are receiving this because you authored the thread.Message ID: ***@***.*** ***@***.***> >
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem with file name sanitization from title. Imported pre-built file sanitizer.
Note: not a JS developer, don't know much about NPM. Please verify changes.