scalar-div-by-2: test with Proptest
#806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
daxpedda
force-pushed
the
scalar-div-by-2-proptest
branch
from
f105e0d to
14ff8c7
Compare
|
I'm fine with this as-is, though after we merge #805 a followup to convert any other randomized testing to proptests would be great (as well as adding new proptests where they make sense). |
tarcieri
approved these changes
Aug 18, 2025
tarcieri
merged commit 11b61a1
into
dalek-cryptography:scalar-div-by-2
23 checks passed
rozbb
pushed a commit
that referenced
this pull request
Aug 22, 2025
* [WIP] Scalar::div_by_2 * debug_assert that carry is 0 * revise tests * Test multiply by half scalar, double and compress (#804) * Test `div_by_2` with `proptest` (#806) --------- Co-authored-by: daxpedda <[email protected]>
|
See #809. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I convert more tests to Proptest right here or in a follow-up?
Alternatively I could make a PR to main adding Proptest and then we can rebase #805 on top of that.