Skip to content

Implement string comparison #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement string comparison #115

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6795c6
Implement comparing strings.
alvra Sep 19, 2023
6a202d5
Document that string comparisons short-circuit if the lengths differ.
alvra Feb 13, 2024
52c3354
Add test for string comparisons.
alvra Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,20 @@ impl<T: ConstantTimeEq> ConstantTimeEq for [T] {
}
}

impl ConstantTimeEq for str {
/// Check whether two strings are equal.
///
/// # Note
///
/// This function short-circuits if the lengths of the input strings
/// are different. Otherwise, it should execute in time independent
/// of the values.
#[inline]
fn ct_eq(&self, rhs: &Self) -> Choice {
self.as_bytes().ct_eq(rhs.as_bytes())
}
}

impl ConstantTimeEq for Choice {
#[inline]
fn ct_eq(&self, rhs: &Choice) -> Choice {
Expand Down