-
Notifications
You must be signed in to change notification settings - Fork 451
Update to Angular 20 #2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Angular 20 #2119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project from Angular 19 to Angular 20, along with updating related dependencies and build configuration. The upgrade was performed using the ng update command and includes both Angular core libraries and Angular ESLint packages.
Key changes:
- Angular core packages updated from ^19.0.1 to ^20.2.3
- Build system migrated from
@angular-devkit/build-angularto the new@angular/buildpackage - Import statements reorganized to consolidate Angular core imports
Reviewed Changes
Copilot reviewed 39 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated Angular dependencies from v19 to v20 and related tooling packages |
| angular.json | Migrated all builder references from @angular-devkit/build-angular to @angular/build |
| Multiple karma.conf.js files | Removed deprecated @angular-devkit/build-angular/plugins/karma plugin references |
| Multiple TypeScript service files | Consolidated import statements to import DOCUMENT from @angular/core instead of @angular/common |
| jwk-window-crypto.service.ts | Updated method parameter type from BufferSource to Uint8Array |
Comments suppressed due to low confidence (1)
projects/sample-implicit-flow-silent-renew/karma.conf.js:1
- Empty array element left after removing the karma plugin. Consider removing the trailing comma on line 12 or adding a comment explaining why this empty element exists.
// Karma configuration file, see link for more information
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
projects/angular-auth-oidc-client/src/lib/utils/url/current-url.service.ts
Outdated
Show resolved
Hide resolved
projects/angular-auth-oidc-client/src/lib/utils/url/current-url.service.spec.ts
Outdated
Show resolved
Hide resolved
…l.service.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…l.service.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
codybtc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xxx
|
Hey, just curious is there an eta for when this will be merged and the next version released? |
|
LGTM I merge and test and will deploy if all is ok |
|
@timdeschryver @FabianGosebrink @codybtc Thanks for the PR. I merged the PR and everything and everything works great. When I try to pack the lib to publish, I get the following errors: Cmd: Any ideas how to fix? |
|
@damienbod I'll take a look at it today. |
|
@timdeschryver Thanks I added this fix: Maybe just review this? I am unsure about the whole schematics part :) I tested everything else and all is working now. |
Upgraded using
ng update: