feat: enable changing temperature with on button when light is on#26
Open
mgrove36 wants to merge 12 commits intodamru:mainfrom
Open
feat: enable changing temperature with on button when light is on#26mgrove36 wants to merge 12 commits intodamru:mainfrom
mgrove36 wants to merge 12 commits intodamru:mainfrom
Conversation
Owner
|
Hey, |
31d0795 to
6865970
Compare
8c0f58e to
0dc796a
Compare
9894685 to
b981c82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Not sure if this is a feature others would find useful, so feel free to close it if not, but I like being able to adjust temperature from the dimmer. I've found the easiest way to do this is just to press the on button (when the light is already on, of course) - similar to how the v1 Philips Hue dimmers (below) work.
This PR changes the default functionality of the on button in the light-only blueprint to increment colour temperature when the light is turned on, instead of forcing the brightness level (if enabled, otherwise doing nothing). There are helper options for configuring max/min temperatures and the step to increment by. The change is handled by adding the step amount to the current temperature, unless the current temperature is greater than or equal to the maximum. Transition time can also be adjusted with a helper option.
This does however require that the light entity supports the
color_tempattribute.Thanks for your work on this blueprint - it's really useful!