-
Notifications
You must be signed in to change notification settings - Fork 303
feat: Add Low Data / Cellular Mode (#919) #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d3vv3r
wants to merge
12
commits into
damus-io:master
Choose a base branch
from
d3vv3r:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9fb0a70
feat: Add Low Data / Cellular Mode (#919)
d3vv3r 8748650
ci: Add GitHub Actions workflow for building Damus
d3vv3r 124fc33
fix: Address CodeRabbit review feedback
d3vv3r 7217e99
docs: Add comprehensive docstrings to all new entities
d3vv3r 7265492
docs: Add CI workflow documentation to DEV_TIPS.md
d3vv3r c2b4a1b
feat: Add Low Data Mode support for profile pictures and banners
d3vv3r b004c12
docs: Add Damus CI status badge to README
d3vv3r 891cb09
fix(low-data): resolve build issues and verify implementation
d3vv3r 0b751e1
chore: address CodeRabbit review (docstrings, swiftlint, formatting)
d3vv3r 6d4f760
chore: finalize CodeRabbit review (README updates, additional docstri…
d3vv3r b789f96
chore: resolve remaining CodeRabbit comments (isPulsing doc, README f…
d3vv3r e30c2d3
chore: resolve merge conflicts with upstream/master
d3vv3r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Damus CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "master", "main" ] | ||
| pull_request: | ||
| branches: [ "master", "main" ] | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build and Test | ||
| runs-on: macos-14 | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Xcode | ||
| uses: maxim-lobanov/setup-xcode@v1 | ||
| with: | ||
| xcode-version: '15.0' | ||
|
|
||
| - name: Build Damus | ||
| run: | | ||
| xcodebuild build \ | ||
| -project damus.xcodeproj \ | ||
| -scheme damus \ | ||
| -destination 'platform=iOS Simulator,name=iPhone 15,OS=latest' \ | ||
| -configuration Debug \ | ||
| CODE_SIGN_IDENTITY="" \ | ||
| CODE_SIGNING_REQUIRED=NO \ | ||
| CODE_SIGNING_ALLOWED=NO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,5 @@ TODO.bak | |
| tags | ||
| build-git-hash.txt | ||
| .build | ||
| build/ | ||
| .swiftpm/ | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 51 additions & 15 deletions
66
damus.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.