fix: bump plist to 1.10.0, pulling patched quick-xml (RUSTSEC-2026-0194, -0195) - #2193
Open
albatrossflyon-coder wants to merge 1 commit into
Open
fix: bump plist to 1.10.0, pulling patched quick-xml (RUSTSEC-2026-0194, -0195)#2193albatrossflyon-coder wants to merge 1 commit into
albatrossflyon-coder wants to merge 1 commit into
Conversation
quick-xml 0.32.0 was locked transitively via syntect -> plist 1.7.0. Two RUSTSEC advisories affect versions before 0.41.0: - RUSTSEC-2026-0194: quadratic run time checking start-tag attributes for duplicate names (CPU-exhaustion DoS) - RUSTSEC-2026-0195: unbounded namespace-declaration allocation in NsReader (memory-exhaustion DoS) syntect uses plist to parse .plist-format theme files, so this is a real attack surface if delta ever processes an untrusted theme file, not just advisory-scanner noise. plist 1.7.0's own dependency constraint caps quick-xml at 0.32.0, so a plain `cargo update -p quick-xml` cannot reach the patched version -- bumping plist to 1.10.0 is required. No source changes needed; full workspace `cargo check` and `cargo test` both pass (414 tests). Fixes dandavison#2183 Fixes dandavison#2184
Contributor
Author
|
Hi — just checking in on this one, it's been open about 7 days with no review yet. Happy to make any changes if there's feedback, or let me know if anything's blocking it. Thanks for maintaining delta! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2183
Fixes #2184
quick-xmlwas locked at 0.32.0, pulled in transitively viasyntect(delta's syntax-highlighting dependency, used to parse.plist-format theme files) →plist1.7.0 →quick-xml0.32.0.Two RUSTSEC advisories affect
quick-xmlbefore 0.41.0:NsReader(memory-exhaustion DoS)Since
syntectusesplistto parse theme files, this is a real attack surface if delta is ever pointed at an untrusted theme file — not just advisory-scanner noise.plist1.7.0's own dependency constraint capsquick-xmlat 0.32.0, so a plaincargo update -p quick-xmlcan't reach the patched version. Bumpingplistto 1.10.0 pulls in the patchedquick-xml0.41.0.No source changes needed —
Cargo.lockonly. Verified:cargo check --workspace— cleancargo test --workspace— 414 passed, 8 ignored