Remove the shadowed file-decoration-style in gruvmax-fang - #2218
Open
VXNCXNX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2211.
What's broken
gruvmax-fangsetsfile-decoration-styletwice, on consecutive lines:git takes the last value, so the first line has never had any effect. It looks like a copy-paste from
nord, which uses that same#434C5Eat line 336.It is not purely cosmetic: a strict INI reader refuses the whole file. Python's
configparserraisesDuplicateOptionErroron it, which is what the issue reports.The fix
Delete the shadowed line. Nothing else in the file has a duplicate key, so this is the only one.
Verification
Effective value is unchanged:
And the file now parses under a strict reader: