show-config: surface $LESSOPEN, $LESS, $PAGER - #2219
Open
albatrossflyon-coder wants to merge 1 commit into
Open
Conversation
These env vars can silently interfere with delta's output (see dandavison#2151, where $LESSOPEN caused a phantom ANSI reset on empty stdin that took real effort to track down) but were invisible in --show-config. Now surfaced alongside delta's own options so a similar issue is faster to diagnose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$LESSOPENsilently caused a phantom ANSI reset on empty stdin — real effort to track down since it's invisible in delta's own config output$LESSOPEN,$LESS, and$PAGERto--show-config's output, as suggested by @HaleTom in that issue, so a similar problem is faster to diagnose next timeunsetwhen the variable isn't set, matching the surrounding styleTest plan
cargo test show_config— both tests pass, including a new one asserting the three env-var lines appearcargo test— full suite passes (416 passed, 0 failed)--show-configoutput: showsunsetfor all three by default, and the real value (e.g.$LESSOPEN) when actually set in the environment