fix(docker): Run ubuntu container as non-root user for security - #2226
Open
vibemasshq-dev wants to merge 1 commit into
Open
fix(docker): Run ubuntu container as non-root user for security#2226vibemasshq-dev wants to merge 1 commit into
vibemasshq-dev wants to merge 1 commit into
Conversation
vibemasshq-dev
force-pushed
the
security/docker-non-root
branch
from
August 30, 2026 23:25
9cb0345 to
93acfa7
Compare
vibemasshq-dev
force-pushed
the
security/docker-non-root
branch
from
August 30, 2026 23:26
93acfa7 to
da6ccbb
Compare
Author
|
Any review on this? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team! Exploring the repo and noticed a quick security tweak for the Docker environment.
1. Security Fix: Docker Container Runs as Root
Currently, the
etc/docker/ubuntu.Dockerfiledoes not specify a user, meaning processes run asrootby default. This increases the container's attack surface.Fix: Added a non-root
appuserand switched the container context to run under it safely.2. Architecture Heads-Up (No Action Required)
As a side note, I was doing some static analysis on the codebase and noticed a potential connection to Issue #2221 (the
git greppanic).The analysis flagged an unhandled
unwrap()call insrc/handlers/grep.rsat line 197 (and 338) ongrep_line.submatches. If the grep output doesn't match exactly what's expected, this will panic the main thread. This perfectly aligns with the stack trace reported in that issue!Also, files like
line_numbers.rsanddiff_header.rsare getting quite large and might be prime candidates for splitting into smaller modules soon.Awesome tool, I use it every day! 🚀