Remove DANDI_SCHEMA_VERSION as a setting#2644
Merged
Conversation
mvandenburgh
approved these changes
Nov 13, 2025
Member
|
LGTM. Funnily enough, setting this env var to a different schema version than the installed |
Member
Author
|
Putting in draft until #2584 is merged. |
Simply import `DANDI_SCHEMA_VERSION` from dandischema.consts
jjnesbitt
force-pushed
the
remove-schema-version-setting
branch
from
1a77548 to
01bfb52
Compare
Member
|
attn @jjnesbitt - #2584 was merged, should we proceed ? |
Member
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2584
For historical reasons, we have a way to specify the dandi schema version as an env var. However, this is never used and is rather nonsensical, since we'd be defining the dandi schema version in conflict with whatever the actual schema version is. As it stands now, the version is pulled from
dandischema.constsanyway. This PR simply imports that value directly fromdandischema, replaces all uses of the setting with that value, and removes the setting.