Return 404 on orphaned assets#2744
Open
jjnesbitt wants to merge 2 commits intodandiset-embargo-end-datefrom
Open
Return 404 on orphaned assets#2744jjnesbitt wants to merge 2 commits intodandiset-embargo-end-datefrom
jjnesbitt wants to merge 2 commits intodandiset-embargo-end-datefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2731
Closes #2733
Orphaned assets can still be accessed via the
/assets/{asset_id}/endpoint. This PR filters out orphaned assets from that endpoint, resulting in a404 Not Foundwhen attempting to access an orphaned asset.