Set Content-Type when uploading certain Zarr entries

[jwodder]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (45ac3d2) to head (b502a48).
Report is 87 commits behind head on master.

Files with missing lines	Patch %	Lines
dandi/files/zarr.py	85.71%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage   88.53%   88.66%   +0.13%     
==========================================
  Files          78       78              
  Lines       10829    10855      +26     
==========================================
+ Hits         9587     9625      +38     
+ Misses       1242     1230      -12     

Flag	Coverage Δ
unittests	88.66% <92.85%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[yarikoptic]

given the discussion in dandi-archive PR, could you please just try uploading some zarr to dandi-staging e.g. to https://gui-staging.dandiarchive.org/dandiset/214256 and see if resultant downloads have correct content encoding and rendered by browser if you visit those urls

[jwodder]

@yarikoptic I uploaded a Zarr to that Dandiset, with Content-Type set in the PUT request, and downloading its .zarray file afterwards via curl -fisSL 'https://api-staging.dandiarchive.org/api/zarr/8c9d4d53-4084-4fc5-9720-0c809a5903ef/files/?prefix=.zarray&download=true' shows "Content-Type: application/json".

rendered by browser if you visit those urls

What URL? If you mean via dandidav, it doesn't cover staging.

[yarikoptic]

pretty much this URL on S3 for the asset you tried: https://dandi-api-staging-dandisets.s3.amazonaws.com/zarr/8c9d4d53-4084-4fc5-9720-0c809a5903ef/.zarray and it is all good! It is different from e.g. https://dandi-api-staging-dandisets.s3.amazonaws.com/zarr/1421096f-3b20-4027-a800-c3fee29b130a/.zarray for a zarr uploaded a year ago and thus without content-types -- browser just offers to download it. So I think we are all good as -- it works!

[yarikoptic]

Looks great, thank you @jwodder, let's proceed

[github-actions]

🚀 PR was released in 0.67.0 🚀