Skip to content

feat: delay `dandischema.models` import in `dandi/download.py`

066e16e
Select commit
Loading
Failed to load commit list.
Draft

Vendorize dandi-cli per config in server info #1661

feat: delay `dandischema.models` import in `dandi/download.py`
066e16e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 21, 2025 in 0s

66.75% (-22.10%) compared to 03b7c07

View this Pull Request on Codecov

66.75% (-22.10%) compared to 03b7c07

Details

Codecov Report

Attention: Patch coverage is 74.02597% with 20 lines in your changes missing coverage. Please review.

Project coverage is 66.75%. Comparing base (03b7c07) to head (066e16e).

Files with missing lines Patch % Lines
dandi/cli/base.py 50.00% 8 Missing ⚠️
dandi/files/bases.py 64.28% 5 Missing ⚠️
dandi/cli/cmd_ls.py 0.00% 1 Missing ⚠️
dandi/dandiset.py 0.00% 1 Missing ⚠️
dandi/files/bids.py 66.66% 1 Missing ⚠️
dandi/files/zarr.py 85.71% 1 Missing ⚠️
dandi/metadata/nwb.py 50.00% 1 Missing ⚠️
dandi/misctypes.py 91.66% 1 Missing ⚠️
dandi/tests/test_metadata.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (03b7c07) and HEAD (066e16e). Click for more details.

HEAD has 552 uploads less than BASE
Flag BASE (03b7c07) HEAD (066e16e)
unittests 553 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1661       +/-   ##
===========================================
- Coverage   88.84%   66.75%   -22.10%     
===========================================
  Files          83       83               
  Lines       11515    11537       +22     
===========================================
- Hits        10230     7701     -2529     
- Misses       1285     3836     +2551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.