Skip to content

Document options for the dandi download --existing flag#1708

Merged
yarikoptic merged 3 commits intodandi:masterfrom
kabilar:download
Oct 6, 2025
Merged

Document options for the dandi download --existing flag#1708
yarikoptic merged 3 commits intodandi:masterfrom
kabilar:download

Conversation

@kabilar
Copy link
Member

@kabilar kabilar commented Sep 18, 2025

For dandi download --existing I am a bit confused as to when to use overwrite-different and refresh so perhaps we can clarify that here.

@kabilar kabilar self-assigned this Sep 18, 2025
@kabilar kabilar added the documentation Changes only affect the documentation label Sep 18, 2025
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.81%. Comparing base (2827711) to head (4883dd5).
⚠️ Report is 125 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1708      +/-   ##
==========================================
- Coverage   74.82%   74.81%   -0.01%     
==========================================
  Files          84       84              
  Lines       11693    11693              
==========================================
- Hits         8749     8748       -1     
- Misses       2944     2945       +1     
Flag Coverage Δ
unittests 74.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kabilar kabilar requested a review from yarikoptic September 18, 2025 18:28

For ``overwrite-different``, if the local file's hash is the same as on the
server, the asset is skipped; otherwise, it is redownloaded.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed corresponding changes to the code -- docs maintained manually in parallel for such ATM

@yarikoptic
Copy link
Member

failing test is unrelated:

FAILED dandi/cli/tests/test_service_scripts.py::test_reextract_metadata - Failed: Timeout (>300.0s) from pytest-timeout.

@yarikoptic yarikoptic merged commit 5c86d03 into dandi:master Oct 6, 2025
40 of 42 checks passed
@github-actions
Copy link

🚀 PR was released in 0.72.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Changes only affect the documentation released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants