Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

The dev version of nwbinspector now requires Python 3.10+, breaking our dev-deps CI job on Python 3.9.

Changes

pyproject.toml

  • Bump requires-python from >=3.9 to >=3.10
  • Remove Programming Language :: Python :: 3.9 classifier
  • Remove eval_type_backport dependency (only needed for Python <3.10)

GitHub Actions workflows

  • run-tests.yml: Remove 3.9 from test matrix; update dandi-api, dev-deps, nfs modes to 3.10
  • lint.yml, typing.yml, release.yml: Update Python version to 3.10
  • docs.yml: Remove 3.9-specific hdf5 install step
Original prompt

This section details on the original issue you should resolve

<issue_title>Drop support of Python 3.9</issue_title>
<issue_description>The dev version of nwbinspector has started requiring Python 3.10 or above, as can be seen in its pyproject.toml file and out failing test:

Image

Let's drop our support for Python 3.10 to be in step with dependencies such as nwbinspector.

Possible steps involved.

  1. Update the Python requirement in pyproject.toml
  2. Remove used of Python 3.9 in test environments.</issue_description>

Comments on the Issue (you are @copilot in this section)

@candleindark Ping @yarikoptic @yarikoptic ok, let's drop altogether because dependency will be released soon with dropped support .... my initial diff was
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index aa01427d..dbebec3f 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -28,10 +28,6 @@ jobs:
       with:
         python-version: ${{ matrix.python }}
 
-    - name: Install hdf5 (Ubuntu)
-      if: matrix.python == '3.9' && startsWith(matrix.os, 'ubuntu')
-      run: sudo apt-get update && sudo apt-get install -y libhdf5-dev
-
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip wheel
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 23486afb..cd620424 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -15,7 +15,7 @@ jobs:
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
-        python-version: '3.9'
+        python-version: '3.10'
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index bcf7673e..8d6f56cc 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -50,7 +50,7 @@ jobs:
             python: 3.13
             mode: obolibrary-only
           - os: ubuntu-latest
-            python: 3.9
+            python: 3.10
             mode: dev-deps
           - os: ubuntu-latest
             python: 3.13

```</body></comment_new>
</comments>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Drop support for Python 3.9 in project Drop support for Python 3.9 Nov 27, 2025
Copilot AI requested a review from yarikoptic November 27, 2025 02:41
@yarikoptic yarikoptic marked this pull request as ready for review November 27, 2025 05:04
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.03%. Comparing base (c43062d) to head (9706277).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
- Coverage   75.06%   75.03%   -0.03%     
==========================================
  Files          84       84              
  Lines       11873    11873              
==========================================
- Hits         8912     8909       -3     
- Misses       2961     2964       +3     
Flag Coverage Δ
unittests 75.03% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@candleindark candleindark added the dependencies Update one or more dependencies version label Nov 27, 2025
@yarikoptic yarikoptic added the patch Increment the patch version when merged label Dec 1, 2025
@yarikoptic yarikoptic merged commit 6b32ff1 into master Dec 1, 2025
41 of 69 checks passed
@yarikoptic yarikoptic deleted the copilot/drop-support-python-3-9 branch December 1, 2025 19:20
candleindark added a commit to dandi/dandi-schema that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update one or more dependencies version patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop support of Python 3.9

3 participants