-
Notifications
You must be signed in to change notification settings - Fork 33
bf(tests): pass DBUS_SESSION_BUS_ADDRESS env var for docker #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Otherwise we observe error getting credentials - err: exit status 1, out: `Cannot autolaunch D-Bus without X11 $DISPLAY` when running undex tox
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1763 +/- ##
=======================================
Coverage 75.03% 75.03%
=======================================
Files 84 84
Lines 11873 11873
=======================================
Hits 8909 8909
Misses 2964 2964
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a D-Bus-related error that occurs when running tests under tox. The error "Cannot autolaunch D-Bus without X11 $DISPLAY" happens during credential operations (likely via the keyring library) when the DBUS_SESSION_BUS_ADDRESS environment variable is not available in the tox test environment.
- Adds
DBUS_SESSION_BUS_ADDRESSto tox'spassenvconfiguration to allow D-Bus communication in test environments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
candleindark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you give a bit more details why we need this? Running tests with tox in a Linux environment when accessing the credential operations? How is this related to docker, as specified in the title.
yes. |
|
decided not to release just yet ;-) |
|
🚀 PR was released in |
Otherwise we observe
error getting credentials - err: exit status 1, out:
Cannot autolaunch D-Bus without X11 $DISPLAYwhen running undex tox.
FWIW, shouldn't help
since that one is not done via tox.