Skip to content

Conversation

@yarikoptic
Copy link
Member

Otherwise we observe

error getting credentials - err: exit status 1, out: Cannot autolaunch D-Bus without X11 $DISPLAY

when running undex tox.

FWIW, shouldn't help

since that one is not done via tox.

Otherwise we observe

  error getting credentials - err: exit status 1, out: `Cannot autolaunch D-Bus without X11 $DISPLAY`

when running undex tox
@yarikoptic yarikoptic requested a review from Copilot December 2, 2025 20:14
@yarikoptic yarikoptic added the tests Add or improve existing tests label Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.03%. Comparing base (a18619e) to head (a38f471).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files          84       84           
  Lines       11873    11873           
=======================================
  Hits         8909     8909           
  Misses       2964     2964           
Flag Coverage Δ
unittests 75.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a D-Bus-related error that occurs when running tests under tox. The error "Cannot autolaunch D-Bus without X11 $DISPLAY" happens during credential operations (likely via the keyring library) when the DBUS_SESSION_BUS_ADDRESS environment variable is not available in the tox test environment.

  • Adds DBUS_SESSION_BUS_ADDRESS to tox's passenv configuration to allow D-Bus communication in test environments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@candleindark candleindark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you give a bit more details why we need this? Running tests with tox in a Linux environment when accessing the credential operations? How is this related to docker, as specified in the title.

@yarikoptic
Copy link
Member Author

Would you give a bit more details why we need this? Running tests with tox in a Linux environment when accessing the credential operations?

yes. docker compose (or docker within) for some reason tries to assess presence of credentials. May be there is another way to make it not do it reliably but I didn't find it . This way I can use tox again and all is good.

@yarikoptic yarikoptic added release Create a release when this pr is merged and removed release Create a release when this pr is merged labels Dec 3, 2025
@yarikoptic
Copy link
Member Author

decided not to release just yet ;-)

@yarikoptic yarikoptic merged commit 598e3da into master Dec 3, 2025
46 checks passed
@yarikoptic yarikoptic deleted the bf-docker-tox branch December 3, 2025 01:47
@github-actions
Copy link

🚀 PR was released in 0.74.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants