Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
- Coverage 75.11% 75.11% -0.01%
==========================================
Files 84 84
Lines 11925 11934 +9
==========================================
+ Hits 8958 8964 +6
- Misses 2967 2970 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
reviewed
Mar 26, 2026
dandi/dandiapi.py
Outdated
|
|
||
| asset_validation_errors: List[RemoteAssetValidationError] | ||
| version_validation_errors: List[RemoteValidationError] | ||
| validation_errors: List[RemoteValidationError] |
Member
There was a problem hiding this comment.
remember that unless upgraded in unison, the same client might need to be used with EMBER running older for a bit, so here might need two different structures depending on server version?
jjnesbitt
force-pushed
the
use-new-asset-validation-errors
branch
from
b516633 to
c78f294
Compare
jjnesbitt
force-pushed
the
use-new-asset-validation-errors
branch
from
c78f294 to
5fa3ede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the CLI to be compatible with dandi/dandi-archive#2719.