Count only for the first hit for subject or tissue within filename#173
Count only for the first hit for subject or tissue within filename#173yarikoptic merged 2 commits intomasterfrom
Conversation
|
i think this also requires line 302 replaced with the sanitize function from dandi-cli. |
fecfb26 to
7b9a460
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 97.91% 97.92%
=======================================
Files 18 18
Lines 2401 2405 +4
=======================================
+ Hits 2351 2355 +4
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
did you try that and it resolved #172? would better be done in a separate PR then since this one does resolve issue too |
7b9a460 to
ed02dec
Compare
I tested, it does. Will submit a complimentary PR. |
Also added assertion so we do not count incorrectly. But may be should be just a warning? Closes #172
d22ac9c to
b749796
Compare
|
ok, i will proceed with this (rebased -- still "worked"). |
|
@yarikoptic - didn't see the ping. this will break number of samples count. it will always be 1. that part should continue to append new tissue samples. |
Also added assertion so we do not count incorrectly. But may be should be just a warning?
Closes #172