[WIP] updating life cycle of dandiset#275
Conversation
…i updates (not sure if we should always run the etst, so for now I added skip); updates to to_datacite function
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 97.54% 89.33% -8.22%
==========================================
Files 16 16
Lines 1753 1819 +66
==========================================
- Hits 1710 1625 -85
- Misses 43 194 +151
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yarikoptic
left a comment
There was a problem hiding this comment.
Thank you!
I left minor comments/wishes
| "assetsSummary": { | ||
| "schemaKey": "AssetsSummary", | ||
| "numberOfBytes": 10, | ||
| "numberOfFiles": 1, | ||
| }, |
There was a problem hiding this comment.
hopefully does not matter but whenever dandiset is created, there is no assets summary yet -- it is done async IIRC, hence
| "assetsSummary": { | |
| "schemaKey": "AssetsSummary", | |
| "numberOfBytes": 10, | |
| "numberOfFiles": 1, | |
| }, |
There was a problem hiding this comment.
assetsSummary is a mandatory field for Dandiset
There was a problem hiding this comment.
in dandi archive we do following if not provided in metadata
if 'assetsSummary' not in metadata:
metadata['assetsSummary'] = {
'schemaKey': 'AssetsSummary',
'numberOfBytes': 0,
'numberOfFiles': 0,
}
http://github.com/dandi/dandi-archive/blob/HEAD/dandiapi/api/models/version.py
to_datacitefunction, so it can also work fordraft