Fix migrate() to update schemaVersion for all migrations, not just pre-0.6.0#354
Merged
yarikoptic merged 4 commits intomasterfrom Nov 25, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 18 18
Lines 2370 2377 +7
=======================================
+ Hits 2320 2327 +7
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The schemaVersion field is now updated for all migrations, not just migrations from versions below 0.6.0. Added test to verify the fix. Co-authored-by: yarikoptic <39889+yarikoptic@users.noreply.github.com>
Co-authored-by: yarikoptic <39889+yarikoptic@users.noreply.github.com>
Member
|
@copilot remember running pre-commit when you commit, or otherwise reacting to lints of that CI run |
Copilot
AI
changed the title
[WIP] Fix
Fix migrate() to update schemaVersion for all migrations, not just pre-0.6.0
Nov 24, 2025
migrate version assignment issue for schema records
Member
|
@copilot -- address pre-commit fixes: and remember to generally prune trailing whitespaces unless they are intentionally added! |
Co-authored-by: yarikoptic <39889+yarikoptic@users.noreply.github.com>
Contributor
Author
Member
|
isn't that what we want to do -- always add target schemaVersion, even if no changes were needed? ;) |
jjnesbitt
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
migrate()function only updatedschemaVersionwhen migrating from versions below 0.6.0, leaving it unchanged for migrations between 0.6.0+ versions (e.g., 0.6.4 → 0.7.0).Changes
schemaVersionassignment outside the pre-0.6.0 conditional block so it executes for all migrationsExample
migratewould assign target version only for records with schema starting versions under 0.6.0 #353Original prompt
migratewould assign target version only for records with schema starting versions under 0.6.0 #353💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.