Skip to content

maint: drop Python 3.9 support, require Python >=3.10#374

Merged
yarikoptic merged 1 commit intodandi:masterfrom
candleindark:update-python-to-3.10
Mar 3, 2026
Merged

maint: drop Python 3.9 support, require Python >=3.10#374
yarikoptic merged 1 commit intodandi:masterfrom
candleindark:update-python-to-3.10

Conversation

@candleindark
Copy link
Member

@candleindark candleindark commented Mar 2, 2026

Summary

  • Remove Python 3.9 from the test matrix in all CI workflows
  • Update python_requires = >=3.10 in setup.cfg
  • Drop the Programming Language :: Python :: 3.9 classifier

Python 3.9 reached end-of-life in October 2024. Additionally,
black>=26.x (pinned in .pre-commit-config.yaml) requires Python>=3.10, making 3.9 incompatible with the current pre-commit setup.

Test plan

  • All CI jobs pass with Python 3.10 as the new minimum
  • Confirm black pre-commit hook installs and runs correctly in the updated environment

🤖 Generated with Claude Code

- Remove Python 3.9 from the test matrix and CI workflows
- Update python_requires to >=3.10 in setup.cfg
- Drop the Python 3.9 classifier

Python 3.10 is the minimum version needed for black>=26.x (used in
pre-commit), and 3.9 reached end-of-life in October 2024.
@candleindark candleindark marked this pull request as draft March 2, 2026 21:41
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.91%. Comparing base (20544c0) to head (5ad8451).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   97.91%   94.91%   -3.00%     
==========================================
  Files          18       18              
  Lines        2401     2401              
==========================================
- Hits         2351     2279      -72     
- Misses         50      122      +72     
Flag Coverage Δ
unittests 94.91% <ø> (-3.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@candleindark candleindark marked this pull request as ready for review March 2, 2026 22:14
@candleindark
Copy link
Member Author

Don't know what
Screenshot 2026-03-02 at 2 14 41 PM

is about? Everything else seems to be good to go.

@candleindark candleindark requested a review from yarikoptic March 2, 2026 22:15
@yarikoptic
Copy link
Member

may be @CodyCBakerPhD would remember when he comes back on where it is required -- I did not see any branch protection rules here, just ignore it

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Mar 3, 2026
@yarikoptic
Copy link
Member

but we apparently do not test 3.13 -- please add in in follow up PR

@yarikoptic yarikoptic merged commit 0a4d2d1 into dandi:master Mar 3, 2026
37 of 38 checks passed
@candleindark
Copy link
Member Author

but we apparently do not test 3.13 -- please add in in follow up PR

#376 create and subsequent PR will follow.

@candleindark candleindark deleted the update-python-to-3.10 branch March 3, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants