ci: remove last use of DANDI_ALLOW_LOCALHOST_URLS env var#375
Merged
yarikoptic merged 1 commit intomasterfrom Mar 3, 2026
Merged
ci: remove last use of DANDI_ALLOW_LOCALHOST_URLS env var#375yarikoptic merged 1 commit intomasterfrom
yarikoptic merged 1 commit intomasterfrom
Conversation
The env var DANDI_ALLOW_LOCALHOST_URLS was removed from the codebase in a12f2e4 (2023), when the DANDI_INSTANCE_URL defaulted to localhost and AnyHttpUrl was used unconditionally. This removes the remaining reference in the dandi-cli test workflow, which has been a no-op since that commit. Closes: #67
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 18 18
Lines 2401 2401
=======================================
Hits 2351 2351
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the last remaining reference to
DANDI_ALLOW_LOCALHOST_URLSfrom
.github/workflows/test-dandi-cli.yml.Why this closes #67
Issue #67 was filed because the codebase required
DANDI_ALLOW_LOCALHOST_URLSto be set in test environments to permit localhost URLs, which were
otherwise rejected by strict URL validation in the Pydantic models.
The root cause was addressed in commit a12f2e4 (2023):
DANDI_INSTANCE_URLwas defaulted to
localhostandAnyHttpUrlwas adoptedunconditionally, eliminating the need for the env var workaround
entirely. Since then,
DANDI_ALLOW_LOCALHOST_URLShas been a no-op —no code in the repository reads it.
This PR removes its last mention in the dandi-cli test workflow,
completing the cleanup originally requested in #67.
This cleanup was identified while running the
/issue-triageskill against the open issues of this repository, which flagged #67 as
likely resolved with HIGH confidence.
Closes #67.
Test plan
DANDI_ALLOW_LOCALHOST_URLSset(no behavioral change expected — the env var has been unread since 2023).
🤖 Generated with Claude Code