Fix multiselection behavior in playlist view #1158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not (permanently) cache all entries of a playlist when the user has made a selection. Only the selected songs are downloaded. When nothing is selected, it will still download the whole playlist.
flyingOwl
force-pushed
the
fix_playlist_multiselection
branch
from
545d8ac to
0f2f108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not (permanently) cache all entries of a playlist when the user has made a selection. Only the selected songs are downloaded. When nothing is selected, it will still download the whole playlist.
All menu items on the playlist view should be aware of a selection made by the user. Currently, the "Cache" and "Permanent Cache" items will download the whole list even when there is a selection. This is because the list of songs to download is overwritten with all playlist entries in
downloadBackground()when the app shows a playlist. My change will skip this if the user has selected songs which are returned bygetSelectedEntries().