Fix rendering after deleting playlist items #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrih
force-pushed
the
fix/remove-from-entry-grid-adapter
branch
from
410c0dc to
b537828
Compare
gravelld
added a commit
to Astiga/Astiga-Android
that referenced
this pull request
Jun 6, 2025
… call getMusicDirectory once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910
The existing method of removing elements from playlist has 2 issues:
This patch users an iterator to correctly keep the data storage state correct and takes advantage of the data binding to the RecyclerView to only update the UI once and directly from the data, instead of pushing remove by index.