Skip to content

fix: absolute URL for correct path resolution in Runner #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

fix: absolute URL for correct path resolution in Runner #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49f3f59
fix: Use absolute URL for process current directory to prevent path r…
Fab1n May 6, 2025
83db0b9
Update CHANGELOG.md
Fab1n May 13, 2025
02f2b94
Update CHANGELOG.md
Fab1n May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@

## Master

## 3.21.2

- Fix Runner's path resolution to enable `--cwd` with relative paths [@Fab1n](https://github.com/Fab1n) - [#650](https://github.com/danger/swift/pull/650)

## 3.21.1

- Fix current directory url creation [@f-meloni][] - [#640](https://github.com/danger/swift/pull/640)
Expand Down
2 changes: 1 addition & 1 deletion Sources/Runner/Commands/Runner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func runDanger(version dangerSwiftVersion: String, logger: Logger) throws {
(cwdOptionIndex + 1) < CommandLine.arguments.count
{
let directoryURL = URL(fileURLWithPath: CommandLine.arguments[cwdOptionIndex + 1])
proc.currentDirectoryURL = directoryURL
proc.currentDirectoryURL = directoryURL.absoluteURL
}
proc.standardOutput = standardOutput
proc.standardError = standardOutput
Expand Down