Skip to content

Additional IE11 select upload fix#1959

Open
wsy89 wants to merge 1 commit intodanialfarid:masterfrom
wsy89:master
Open

Additional IE11 select upload fix#1959
wsy89 wants to merge 1 commit intodanialfarid:masterfrom
wsy89:master

Conversation

@wsy89
Copy link

@wsy89 wsy89 commented Jun 29, 2017

ngf-select is triggering file change twice in IE11 and this is making my model null.
I know there was fix done in previous version by checking if the fileList is null in changeFn function but in my case, the list is not null but it was empty. This result in nullifying my file object.

@Celadora
Copy link

Celadora commented Jul 11, 2017

Just a heads up, this is still occurring in Chrome Version 59.0.3071.115 (Official Build) (64-bit), even with this patch applied.

Here is one example with the bug emphasized with an alert box:
http://jsfiddle.net/2vq88rfs/1431/

To reproduce: select a file, open it, select a file a second time.

Note that the alert prompt will be displayed before the open file prompt (which will still open over the alert).

@wsy89
Copy link
Author

wsy89 commented Jul 11, 2017

It looks like that will also go away once this patch is applied. I am still waiting for the owner of this library to accept the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants