fix: improve regexp for options parser to fix preview #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only match option followed by space, to avoid accidentally matching options containing a keyword, such as `--preview-path`. - only match option at start of line, to avoid matching keywords within help text of other options, for example: > --taesd-preview-only prevents usage of taesd for decoding the final image. > (for use with --preview tae)
|
I haven't tested that branch for a while so I forgot to check for it. Thanks for the fix. |
|
Since you're using the changes from stduhpf's fork if you happen to find any other interesting option feel free to open an issue with the potential enhancement or a PR with the required changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the preview options parsing based on latest code on leejet/stable-diffusion.cpp#522
The joys of living on the bleeding edge!