Added support for image download; Removed the file name trimming#8
Open
license2e wants to merge 1 commit intodaniel-sc:masterfrom
license2e:master
Open
Added support for image download; Removed the file name trimming#8license2e wants to merge 1 commit intodaniel-sc:masterfrom license2e:master
license2e wants to merge 1 commit intodaniel-sc:masterfrom
license2e:master
Conversation
…g since it also removed the extension Signed-off-by: license2e <ilya@shindyapin.com>
Owner
There was a problem hiding this comment.
Here should be something like array_merge to account for multiple image fields in one item.
Author
There was a problem hiding this comment.
You are probably correct, I will have to spin up an organization to test that out, since I only have one image field.
Owner
|
Hi @license2e , thank you very much for contributing!! I have just some two remarks before merge:
Feel free to explain why/that I'm wrong or refactor ;) Regards, Daniel |
Contributor
|
It's a pitty this hasn't been merged, it's the missing feature, I'll see if I can do something |
Owner
|
Hi @aseques - you are very welcome to elaborate on the missing bits (see my comment) - then I'll happily merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for image download to complete the full export functionality
Also, removed the file name trimming since it also removed the file extension
Signed-off-by: license2e ilya@shindyapin.com