Skip to content

gracefully handle deleting modelMax through input #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

gracefully handle deleting modelMax through input #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion angular.rangeSlider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,18 @@
if (scope.pinHandle !== 'max') {
throwWarning('modelMax must be a number');
}
scope.modelMax = scope.max;
// scope.modelMax = scope.max;

// if deleted with backspace in a type="number" input, the value is set to null
if (scope.modelMax === null) {
if (scope.modelMin) {
scope.modelMax = scope.modelMin
} else if (scope.min) {
scope.modelMax = scope.min;
} else {
scope.modelMax = 0;
}
}
}

var handle1pos = restrict(((scope.modelMin - scope.min) / range) * 100),
Expand Down