Skip to content

fix issue #1029 EnableIndexes is set to false but Index-related work are still being queued #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #1029 EnableIndexes is set to false but Index-related work are still being queued #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/providers/WorkflowCore.Providers.Redis/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public static class ServiceCollectionExtensions
{
public static WorkflowOptions UseRedisQueues(this WorkflowOptions options, string connectionString, string prefix)
{
options.UseQueueProvider(sp => new RedisQueueProvider(connectionString, prefix, sp.GetService<ILoggerFactory>()));
options.UseQueueProvider(sp => new RedisQueueProvider(connectionString, prefix, sp.GetService<WorkflowOptions>(), sp.GetService<ILoggerFactory>()));
return options;
}

Expand Down
22 changes: 20 additions & 2 deletions src/providers/WorkflowCore.Providers.Redis/Services/RedisQueueProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using Microsoft.Extensions.Logging;
using StackExchange.Redis;
using WorkflowCore.Interface;
using WorkflowCore.Models;

namespace WorkflowCore.Providers.Redis.Services
{
Expand All @@ -24,15 +25,27 @@ public class RedisQueueProvider : IQueueProvider
[QueueType.Index] = "index"
};

public RedisQueueProvider(string connectionString, string prefix, ILoggerFactory logFactory)
private readonly Dictionary<QueueType, bool> _enabledQueues = new Dictionary<QueueType, bool>
{
};

public RedisQueueProvider(string connectionString, string prefix, WorkflowOptions options, ILoggerFactory logFactory)
{
_connectionString = connectionString;
_prefix = prefix;
_enabledQueues[QueueType.Index] = options.EnableIndexes;
_enabledQueues[QueueType.Event] = options.EnableEvents;
_enabledQueues[QueueType.Workflow] = options.EnableWorkflows;
_logger = logFactory.CreateLogger(GetType());
}

public async Task QueueWork(string id, QueueType queue)
{
if (!_enabledQueues[queue])
{
return;
}

if (_redis == null)
throw new InvalidOperationException();

Expand All @@ -47,6 +60,11 @@ public async Task QueueWork(string id, QueueType queue)

public async Task<string> DequeueWork(QueueType queue, CancellationToken cancellationToken)
{
if (!_enabledQueues[queue])
{
return null;
}

if (_redis == null)
throw new InvalidOperationException();

Expand Down