Nonoptimal database query #1302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martikyan
reviewed
Nov 11, 2024
| .ThenInclude(ep => ep.ExtensionAttributes) | ||
| .Include(wf => wf.ExecutionPointers) | ||
| .AsSplitQuery() | ||
| .FirstAsync(x => x.InstanceId == uid, cancellationToken); |
There was a problem hiding this comment.
Suggested change
| .FirstAsync(x => x.InstanceId == uid, cancellationToken); | |
| .FirstOrDefaultAsync(x => x.InstanceId == uid, cancellationToken); |
because it seems you're checking for raw being not null
Author
There was a problem hiding this comment.
danielgerlag
requested changes
Nov 15, 2024
| subscription.Id = Guid.NewGuid().ToString(); | ||
| var persistable = subscription.ToPersistable(); | ||
| var result = db.Set<PersistedSubscription>().Add(persistable); | ||
| _ = db.Set<PersistedSubscription>().Add(persistable); |
Owner
There was a problem hiding this comment.
Could we put non-related changes in their own PR?
danielgerlag
approved these changes
Sep 12, 2025
Owner
|
@copilot please resolve the conflicts |
Owner
|
The breaking changes to the integration tests are holding back this PR. |
Owner
|
@copilot please recreate this PR, but without all the unnecessary changes. Only include the Linq changes, please exclude the changes to the integrations tests where generic parameters are being added. Also please leave out the formatting changes. |
3 tasks
Owner
|
succeeded by #1399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
#1169