fix: prevent panic when text value sent to FormFile field #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip FormFile and []FormFile fields in formValueParser to prevent panic when multipart form data contains text values for fields expecting file uploads. Previously, sending a text value to a FormFile field would cause parseInto() to panic with 'unsupported param type huma.FormFile'. Now it properly returns a validation error 'File required'. Partially fixes danielgtaylor#912
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a panic that occurred when multipart form data contains text values (without filename) for fields expecting file uploads. The fix prevents parseInto() from attempting to parse FormFile types by skipping them in the formValueParser, allowing the proper file handling code to return a validation error instead.
- Skip FormFile and []FormFile fields in formValueParser to prevent panic
- Add comprehensive test case for text value sent to FormFile field
- Ensures proper "File required" validation error is returned
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| huma.go | Adds early return in formValueParser to skip FormFile and []FormFile fields, preventing panic in parseInto() |
| huma_test.go | Adds test case validating that text values sent to FormFile fields return proper validation error instead of panicking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rison This change improves the type checking for FormFile fields by using reflect.TypeOf() for direct type comparison instead of string comparison. This is more reliable and performant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip FormFile and []FormFile fields in formValueParser to prevent panic when multipart form data contains text values for fields expecting file uploads.
Previously, sending a text value to a FormFile field would cause parseInto() to panic with 'unsupported param type huma.FormFile'. Now it properly returns a validation error 'File required'.
Partially fixes #912