-
Notifications
You must be signed in to change notification settings - Fork 232
betterproto: support Struct
and Value
#551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Gobot1234
merged 9 commits into
danielgtaylor:master
from
trail-of-forks:tob-struct-support
Jan 2, 2024
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cd39656
betterproto: support `Struct` and `Value`
woodruffw f5a3eee
betterproto: handle struct in to_dict as well
woodruffw c8e6244
tests: add Struct roundtrip tests
woodruffw 8ed15a1
specialize from_dict and to_dict on Struct
woodruffw d7ef248
betterproto: `poe format`
woodruffw 1b887ba
Update src/betterproto/__init__.py
woodruffw 49df234
remove future annotations
woodruffw dde445d
replace type[...] with typing.T
woodruffw bc527f5
quote instead
woodruffw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import json | ||
|
||
from betterproto.lib.google.protobuf import Struct | ||
|
||
|
||
def test_struct_roundtrip(): | ||
data = { | ||
"foo": "bar", | ||
"baz": None, | ||
"quux": 123, | ||
"zap": [1, {"two": 3}, "four"], | ||
} | ||
data_json = json.dumps(data) | ||
|
||
struct_from_dict = Struct().from_dict(data) | ||
assert struct_from_dict.fields == data | ||
assert struct_from_dict.to_json() == data_json | ||
|
||
struct_from_json = Struct().from_json(data_json) | ||
assert struct_from_json.fields == data | ||
assert struct_from_json == struct_from_dict | ||
assert struct_from_json.to_json() == data_json |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.