pixelbender: Distinguish Meta1 and Meta2 opcodes

This is useful for disassembly.

Author: kjarosh

render/pixel_bender/src/parser.rs

@@ -350,6 +350,7 @@ pub enum PixelBenderParam {
 pub struct PixelBenderMetadata {
     pub key: String,
     pub value: PixelBenderType,
+    pub is_meta2: bool,
 }
 
 /// Parses PixelBender bytecode
@@ -469,6 +470,7 @@ fn read_op<R: Read>(
             metadata.push(PixelBenderMetadata {
                 key: meta_key,
                 value: meta_value,
+                is_meta2: matches!(opcode, Opcode::PBJMeta2),
             });
         }
         Opcode::PBJParam => {

render/pixel_bender/src/tests.rs

@@ -82,18 +82,22 @@ fn simple_shader() {
                         value: PixelBenderType::TString(
                             "The size of the image to which the kernel is applied".to_string(),
                         ),
+                        is_meta2: true,
                     },
                     PixelBenderMetadata {
                         key: "minValue".to_string(),
                         value: PixelBenderType::TFloat2(0.0, 0.0),
+                        is_meta2: true,
                     },
                     PixelBenderMetadata {
                         key: "maxValue".to_string(),
                         value: PixelBenderType::TFloat2(100.0, 100.0),
+                        is_meta2: true,
                     },
                     PixelBenderMetadata {
                         key: "defaultValue".to_string(),
                         value: PixelBenderType::TFloat2(50.0, 50.0),
+                        is_meta2: true,
                     },
                 ],
             },
@@ -110,18 +114,22 @@ fn simple_shader() {
                     PixelBenderMetadata {
                         key: "description".to_string(),
                         value: PixelBenderType::TString("The radius of the effect".to_string()),
+                        is_meta2: true,
                     },
                     PixelBenderMetadata {
                         key: "minValue".to_string(),
                         value: PixelBenderType::TFloat(0.0),
+                        is_meta2: true,
                     },
                     PixelBenderMetadata {
                         key: "maxValue".to_string(),
                         value: PixelBenderType::TFloat(50.0),
+                        is_meta2: true,
                     },
                     PixelBenderMetadata {
                         key: "defaultValue".to_string(),
                         value: PixelBenderType::TFloat(25.0),
+                        is_meta2: true,
                     },
                 ],
             },
@@ -130,20 +138,24 @@ fn simple_shader() {
             PixelBenderMetadata {
                 key: "namespace".to_string(),
                 value: PixelBenderType::TString("Adobe::Example".to_string()),
+                is_meta2: false,
             },
             PixelBenderMetadata {
                 key: "vendor".to_string(),
                 value: PixelBenderType::TString("Adobe examples".to_string()),
+                is_meta2: false,
             },
             PixelBenderMetadata {
                 key: "version".to_string(),
                 value: PixelBenderType::TInt(1),
+                is_meta2: false,
             },
             PixelBenderMetadata {
                 key: "description".to_string(),
                 value: PixelBenderType::TString(
                     "A shader that does nothing, but does it well.".to_string(),
                 ),
+                is_meta2: false,
             },
         ],
         operations: vec![