Skip to content

fix(algorithm.ts): stopLoop terminal state guard + regex escaping #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rikitikitavi2012-debug wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(algorithm.ts): stopLoop terminal state guard + regex escaping #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Releases/v4.0.3/.claude/PAI/Tools/algorithm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,9 @@ function updateFrontmatter(path: string, updates: Record<string, unknown>): void

for (const [key, value] of Object.entries(updates)) {
const strVal = value === null ? "null" : String(value);
const regex = new RegExp(`^(${key}):.*$`, "m");
// Escape regex metacharacters in key to prevent injection
const escapedKey = key.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
const regex = new RegExp(`^(${escapedKey}):.*$`, "m");
if (regex.test(yamlBlock)) {
yamlBlock = yamlBlock.replace(regex, `${key}: ${strVal}`);
} else {
Expand Down Expand Up @@ -1438,6 +1440,11 @@ async function resumeLoop(prdPath: string): Promise<void> {
function stopLoop(prdPath: string): void {
const absPath = resolve(prdPath);
const { frontmatter } = readPRD(absPath);
// Guard: don't overwrite terminal states (matches pauseLoop's pattern)
if (frontmatter.loopStatus === "completed" || frontmatter.loopStatus === "failed") {
console.log(`Loop already ${frontmatter.loopStatus} on ${frontmatter.id} — not modifying.`);
return;
}
updateFrontmatter(absPath, { loopStatus: "stopped" });
voiceNotify(`Loop stopped on ${frontmatter.id}.`);
console.log(`\x1b[31m\u25A0 Stopped\x1b[0m Loop on ${frontmatter.id}`);
Expand Down