Have 'diskspace', 'tunnel ls', and 'devmode get' output unformatted JSON #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without --nojson flag remove extranous nil check before exitIfError
aluedeke
approved these changes
Jan 19, 2026
Collaborator
|
@toratora could you pelase resolve the conflicts? |
…ithub.com:toratora/go-ios into json-output-for-diskspace-tunnel-devmode-commands
Contributor
Author
|
@aluedeke Done. Rebased on top of |
Collaborator
|
@toratora This PR needs a rebase against main to resolve conflicts in the help text section of main.go. The functional code changes look good - just the documentation formatting needs to be resolved. |
added 2 commits
January 26, 2026 08:22
…without --nojson flag remove extranous nil check before exitIfError
…ithub.com:toratora/go-ios into json-output-for-diskspace-tunnel-devmode-commands
Contributor
Author
|
@aluedeke Rebased on top of |
toratora
deleted the
json-output-for-diskspace-tunnel-devmode-commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
diskspacecommand only output formatted non-JSON. Now JSON is output, respecting--nojsonflag.Before this change
tunnel lsonly output formatted JSON, now it usesconvertToJSONStringto output JSON, and respects--nojsonflag outputting formatted non-JSON.Before this change
devmode getoutput only non-JSON. Now JSON is output, respecting--nojsonflag.Removed extraneous
nilcheck beforeexitIfError