Enable using polr shortener instead tinyurl#8
Enable using polr shortener instead tinyurl#8mzagar wants to merge 2 commits intodanielyaa5:mainfrom
Conversation
|
@danielyaa5 any chance to merge/release this ? please let me know if something needs improving... |
danielyaa5
left a comment
There was a problem hiding this comment.
Thanks a lot for this! Just some small changes requested. How does POLR compare to tiny URL?
…ning; minor code improvements.
|
Hi, sorry for the delay - proposed improvements implemented, please review the changes. |
danielyaa5
left a comment
There was a problem hiding this comment.
Looks good, one last thing. Can you tell me why you want to have POLR supported? I don't know anything about it. Why is it better than tinyurl?
|
Regarding why polr - please see description of this PR -- not that it is better than tinyurl, just open source and happens to be something I am already running locally for shorting urls and would not like to change by introducing tinyurl; main goal is to keep diagrams inhouse and not send them to 3rd party services. |
|
thanks, i will take a final pass at this soon! |
Added an option to specify polr shortner url in which case polr shortener API will be called to shorten url instead using tinyurl.
I'd like to use polr since it's open source and am able to run it locally which allows me, together with running plantuml server locally, not to send diagrams to 3rd party services but keep everything in-house.
Quick test:
./index.js --polr-url https://demo.polr.me/