Split get_weight_compression_parameters on get_params/collect_statistics#43
Open
daniil-lyakhov wants to merge 2 commits intodevelopfrom
Open
Split get_weight_compression_parameters on get_params/collect_statistics#43daniil-lyakhov wants to merge 2 commits intodevelopfrom
daniil-lyakhov wants to merge 2 commits intodevelopfrom
Conversation
daniil-lyakhov
commented
Oct 2, 2025
Comment on lines
+909
to
+911
| all_weight_params, ratio_defining_params, group_size_values = self.get_weight_compression_parameters( | ||
| model, graph | ||
| ) |
Owner
Author
There was a problem hiding this comment.
all_weight_params, ratio_defining_params, group_size_values = self._quantizer.get_weight_compression_parameters(
model, graph
)
quantizer doesn't need sensetivity metrics/ ratio and etc. It is the basic mixed precision: if the node is embedding node/ last node/ conv node- it is in the backup precision. Have to keep backup precision though
daniil-lyakhov
commented
Oct 2, 2025
src/nncf/quantization/algorithms/weight_compression/algorithm.py
Outdated
Show resolved
Hide resolved
daniil-lyakhov
commented
Oct 2, 2025
daniil-lyakhov
commented
Oct 2, 2025
Owner
Author
daniil-lyakhov
left a comment
daniil-lyakhov
left a comment
There was a problem hiding this comment.
Aamir, could you please try to work on top of this refactoring? Would it possible to separate quantizer/algorithm the way I described in the comments?
daniil-lyakhov
commented
Oct 2, 2025
| all_weight_params, ratio_defining_params, group_size_values = self.get_weight_compression_parameters( | ||
| model, graph | ||
| ) | ||
| return self.apply_with_parameters( |
Owner
Author
There was a problem hiding this comment.
self._algo.apply_with_parameters(
model,
graph,
dataset,
statistic_points,
all_weight_params,
ratio_defining_params,
group_size_values,
)
algo has all required params like sencetivity metric/ ratio and etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reason for changes
Related tickets
Tests