fix to enable using UUIDs/non-default PKs #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrDlouhy
force-pushed
the
fix_pks
branch
3 times, most recently
from
149d38f to
493542c
Compare
PetrDlouhy
force-pushed
the
fix_pks
branch
4 times, most recently
from
56f1a4e to
a9dfa2b
Compare
|
The changes in the core code code contained in this PR are overridden by #374, although the new tests should be still valid and work with the new code there. |
danirus
reviewed
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use UUIDs as PKs as mentioned in #179, and the only problem preventing that was these two small misuses of ID instead of PK.