Merged
Conversation
* The INSTALLED_APP order matters for the template overriding user's own app order should go before django_comments_xtd
Owner
|
Thanks for the fix, @tkin91e55. And yes, I think it makes sense to add a reminder of the template loading order in the docs. I can add it, but if you prefer it, you can add it in this very PR too. |
danirus
approved these changes
Jan 7, 2025
Merged
Owner
|
Docs extended in PR 449. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May remind user the template overriding order somewhere in documentation.
For example:
Refer to django-contrib-comments, https://github.com/django/django-contrib-comments/blob/2.2.0/django_comments/templatetags/comments.py#L184
if the app specific template search is supported, it would be nicer.