allow value field name in combination with builder#131
Open
Conversation
danlehmann
approved these changes
Mar 13, 2026
Owner
|
Thanks for the fix! Quick question: What if we made it a tuple struct instead? That Regardless, would you mind adding a note to the changelog? |
Collaborator
Author
Good idea. no renaming needed then. Might try this. |
Collaborator
Author
|
Okay, I pushed the change to use a unit tuple structure. however, I still need to mangle the |
robamu
force-pushed
the
allow-value-field-names-with-builder-2
branch
from
ec33327 to
fd99bd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126