-
Notifications
You must be signed in to change notification settings - Fork 94
selfcheck.sh: also run with system includes made available #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
This fails with The code in question: #if __has_include(<sys/single_threaded.h>)
# include <sys/single_threaded.h>
#endif |
508ffaf to
fdae274
Compare
dd1cc3f to
fbb316f
Compare
|
It now fails with or |
8af58e9 to
a21478b
Compare
34115d6 to
d7eaeb7
Compare
eebcb44 to
2760f96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. my problem with this could be that maybe there will be problem in CI and no problem locally .. or no problem in CI today and then we get problems a year from now.
are the headers in a github runner fixed so they are never changed? or can they be changed at anytime (from one day to the next)?
Yes, that is a bit of a shortcoming. That might need some adjustment if encountered. But as we are just checking for errors and not the actual output it should be fine.
That can happen with anything in any workflow because the runners (and all other parts of the GitHub workflows) are constantly changing.
No, they are not. But as mentioned above that is an issue we are constantly facing with any part of GitHub workflows. |
This comment was marked as resolved.
This comment was marked as resolved.
e779362 to
b0b0573
Compare
|
After integrating this with MinGW I have a few cleanups for this. |
I think I have that figured out as well. |
This comment was marked as resolved.
This comment was marked as resolved.
81a82d0 to
6abcbe6
Compare
| @@ -1,11 +1,111 @@ | |||
| #!/bin/sh | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed so the <<< syntax works.
6abcbe6 to
31088a9
Compare
31088a9 to
35346ef
Compare
No description provided.